feat(web): open access to any authenticated user, remove ZPA#132
Merged
Conversation
There is no login allowlist anymore. The auth proxy (oauth2-proxy, restricted to the hm.edu domain) is the sole access boundary: anyone it authenticates is let in and acts strictly as their own user (per-user isolation is unchanged). This drops the users collection, the auth.seedusers seeding, and the 403 "not on the allowlist" path — a colleague no longer has to be added by hand. The ZPA (Prüfungsamt) integration is removed entirely, along with the students page it fed. Its per-email lookup let any logged-in user pull personal exam- office data (name, Matrikelnummer, gender, study programme) for arbitrary HM emails — the reason the allowlist existed. Removing ZPA removes that exposure, so opening access is safe. Existing configs keep working: leftover auth.seedusers / zpa.* keys are simply ignored. The now-unused users collection can be dropped from Mongo at leisure. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was
Kein Login-Allowlist mehr: der Auth-Proxy (oauth2-proxy, auf
hm.edubeschränkt) ist die einzige Zugangsgrenze. Jede authentifizierte Kennung kommt rein und arbeitet strikt als eigener Nutzer (Owner-Isolation unverändert). Kolleg:innen müssen nicht mehr von Hand eingetragen werden.Die ZPA-Anbindung (Prüfungsamt) wird komplett entfernt, samt der Studierenden-Seite, die sie speiste. Deren Per-E-Mail-Lookup erlaubte jedem eingeloggten Nutzer, personenbezogene Daten (Name, Matrikelnummer, Geschlecht, Studiengang) zu beliebigen HM-Mails zu ziehen — genau der Grund, aus dem die Allowlist existierte. Ohne ZPA entfällt dieses Risiko, daher ist das Öffnen des Zugangs unbedenklich.
Änderungen
auth.go: Allowlist-Check raus; User ausX-Remote-User+X-Remote-Displayname. Nur fehlender Header ist noch 401.web/zpa/,web/app/students.go,web/graph/students.graphqls+resolver,web/bootstrap/seed.go,web/db/users.go(dieusers-Collection war ausschließlich die Allowlist).app.go/bootstrap.go:GetUserByEmail,zpa-Feld/-Param,seedUsers,EnsureUserIndexesweg; gqlgen neu generiert.seedusers/zpa) bereinigt.Kompatibilität
Kein Breaking-Change-Marker: bestehende Configs laufen weiter, übrig gebliebene
auth.seedusers/zpa.*-Keys werden ignoriert. Die verwaisteusers-Collection kann bei Gelegenheit aus Mongo gedroppt werden.Checks
gofmt·go vet ./...·go vet -tags=integration ./...·go test ./...·golangci-lint run— alle grün.🤖 Generated with Claude Code